Fix CRAN connection issues #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in check package
Work on #113 for vignette
|
About bumping version, I didn't. I let you choose about it. Feel free to commit, of course. |
It's already present at the begin of the test
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 420 420
=========================================
Hits 420 420 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
peterdesmet
reviewed
Nov 16, 2022
I tested all the tests without an internet connection and removed the testthat::skip_if_offline() where the test still passed without it
|
@peterdesmet: I see you removed some "skips". Are you sure? You need internet connection for reading |
peterdesmet
force-pushed
the
fix-cran-issues
branch
from
700a351
to
efb3468
Compare
Yes, I tested all. |
I kept CRAN in relatedLink and provider in codemeta.json
peterdesmet
force-pushed
the
fix-cran-issues
branch
from
33789b4
to
0ca101b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #113, #114 and #115.
I used
testthat::skip_if_offline()where needed in each of the test files. I preferred this skip function overtestthat::skip_on_cran(). In this way a developer is free to test the package even if internet is (temporarily) unavailable.About the vignette: I transformed some R chunks to markdown code where strictly needed. I know, this is not really elegant but I don't see really any other valid solution. Using package
mockeryand its functionstub()will be way far less elegant than the solution proposed here.